Skip to content

[vertexai] Use correct name in release notes for vertexai #6976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

[vertexai] Use correct name in release notes for vertexai #6976

merged 1 commit into from
May 20, 2025

Conversation

@rlazo
Copy link
Collaborator

@rlazo rlazo commented May 20, 2025

The release note name has been updated to use the correct value.

Context cl/761183261

@rlazo
Use correct name in release notes for vertexai
7e55ff7 
The release note name has been updated to use the correct value.

Context cl/761183261
@rlazo rlazo requested a review from daymxn May 20, 2025 20:09
@rlazo rlazo enabled auto-merge (squash) May 20, 2025 20:09
@rlazo rlazo requested a review from davidmotson May 20, 2025 20:09
@github-actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@rlazo rlazo changed the title Use correct name in release notes for vertexai [vertexai] Use correct name in release notes for vertexai May 20, 2025
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (9c00477) and merge commit (adada74).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Z9ccZLwBtq.html

@github-actions
Copy link
Contributor

Test Results

 18 files   -  6   18 suites   - 6   34s ⏱️ -2s
 88 tests  - 14   88 ✅  - 14  0 💤 ±0  0 ❌ ±0 
176 runs   - 28  176 ✅  - 28  0 💤 ±0  0 ❌ ±0 

Results for commit 7e55ff7. ± Comparison against base commit 9c00477.

This pull request removes 102 and adds 88 tests. Note that renamed tests count towards both. 
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ image rejected
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ long reply
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ prompt blocked for safety
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ short reply
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ stopped for recitation
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ citation returns correctly
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ invalid api key
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ long reply
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ response blocked for safety
…

com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.SerializationTests ‑ test Candidate serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test GenerateContentResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test Schema serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test countTokensResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test modalityTokenCount serialization as Json
com.google.firebase.vertexai.VertexAIStreamingSnapshotTests ‑ citation parsed correctly
…

@rlazo rlazo merged commit 5db7bfb into main May 20, 2025
32 checks passed
@rlazo rlazo deleted the rlazo-patch-2 branch May 20, 2025 20:20
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (9c00477) and merge commit (adada74).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ac0bu4zyim.html

@firebase firebase locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidmotson davidmotson davidmotson approved these changes

@daymxn daymxn Awaiting requested review from daymxn

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rlazo @google-oss-bot @davidmotson